search

ansible-collections / community.general

Ansible Community General Collection
https://galaxy.ansible.com/ui/repo/published/community/general/
GNU General Public License v3.0
838 stars 1.54k forks source link

keycloak_client and saml_signature_canonicalization_method parameter #3790

Open haresotto opened 3 years ago

haresotto commented 3 years ago

Summary

Hello, Sorry for my poor english ;-) The documentation reads, for the "saml_signature_canonicalization_method" parameter of keycloak_client : 

 SAML signature canonicalization method. This is one of four values, namely **http://www.w3.org/2001/10/xml-exc-c14n#** for
EXCLUSIVE, **http://www.w3.org/2001/10/xml-exc-c14n#WithComments** for EXCLUSIVE_WITH_COMMENTS,
**http://www.w3.org/TR/2001/REC-xml-c14n-20010315** for INCLUSIVE, and **http://www.w3.org/TR/2001/REC-xml-
c14n-20010315#WithComments** for INCLUSIVE_WITH_COMMENTS.

From a user perspective, I think that filling the parameter saml_signature_canonicalization_method with, for example, "EXCLUSIVE" is way more intuitive than "http://www.w3.org/2001/10/xml-exc-c14n#" , because that is what one can find in the UI. I failed at first because of this. Don't you think that this would be better and easier to use?

Issue Type

Feature Idea

Component Name

keycloak_client

Additional Information

This would be used as saml_signature_canonicalization_method: EXCLUSIVE|EXCLUSIVE_WITH_COMMENTS|INCLUSIVE... which would be easier to use/remember

Code of Conduct

ansibullbot commented 3 years ago

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot commented 3 years ago

cc @eikef @ndclt click here for bot help

ansibullbot commented 2 years ago

Files identified in the description:

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot commented 1 year ago

cc @mattock click here for bot help

ansibullbot commented 4 months ago

cc @thomasbach-dev click here for bot help