search

ansible-collections / community.general

Ansible Community General Collection
https://galaxy.ansible.com/ui/repo/published/community/general/
GNU General Public License v3.0
810 stars 1.49k forks source link

terraform: workspace creation is now broken #6101

Open felixfontein opened 1 year ago

felixfontein commented 1 year ago

Summary

I recently upgraded community.general in one of our project, and I believe #5832 didn't solve a bug but actually introduced one: the terraform module is now unable to create workspaces when they do not exist.

Initialisation happens on line 498, and this PR includes the workspace right in it, but creation of said workspace only happens on line 503. Hence for our playbooks to work, we now have to manually create workspaces before initialisation.

I believe this is both a breaking change and something that is quite contrary to the way Terraform actually works. Although I understand @dorkamotorka's use case, could we revert this change until a more battle-proven solution is on the table ?

Originally posted by @MehuiSeklayr in https://github.com/ansible-collections/community.general/issues/5735#issuecomment-1438085655

Issue Type

Bug Report

Component Name

plugins/modules/terraform.py

Ansible Version

doesn't matter

felixfontein commented 1 year ago

CC @dorkamotorka

ansibullbot commented 1 year ago

cc @m-yosefpor @rainerleber click here for bot help

MehuiSeklayr commented 1 year ago

Hi @felixfontein Have you got any news regarding this issue ? Can I help in any way ? Have a great day :)

felixfontein commented 1 year ago

@MehuiSeklayr I'm not sure whether anyone is still working on this module, since there now is a better maintained copy in a new collection cloud.terraform - see https://github.com/ansible-community/community-topics/issues/192.

MehuiSeklayr commented 1 year ago

@felixfontein I was definitely not aware of cloud.terraform I will look into it right now, and eventually work on a migration. Feel free to close this ticket, then :) Thank you so much !