Closed cwchristerw closed 1 year ago
Files identified in the description:
If these files are incorrect, please update the component name
section of the description or use the !component
bot command.
cc @Akasurde @Nosmoht @fxfitz @justchris1 click here for bot help
Hi @cwchristerw ,
Thanks for reporting! Would you be interested in working on a pull request for this?
I would suspect this is not a requirement for all states. Could you please confirm?
Yes I can make PR, and I'll check it. It's required at least when present and user isn't existing. I'll test if its required when enabled and then report back here. I'll do it ASAP, tomorrow.
Sounds to me like this should be simply documented (without a code change), since the module (via the API) already reports an error if this is missing.
Yes I agree :smile: I haven't made Docs Only PR yet :smile:
Sounds to me like this should be simply documented (without a code change), since the module (via the API) already reports an error if this is missing.
Not sure - not checking right now - but I believe that error message is coming from the API. If we can determine with some confidence that these parameters are (always) going to be required for some of the actions, the module could perform a param validation (using required_if
, other required
clauses, or an actual if
in the code) before hitting the API, thus saving that HTTP request.
@russoz they seem to be needed on creation, but not on update - so requiring them for state=present
would be a breaking change.
Well, in that case it is indeed a simple Docs PR. :-)
@cwchristerw please let us know if you need any further guidance, but I strongly recommend going through the https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md docs if you have not raised a PR for the collection before.
I haven't had time for past two weeks but I have time to do PR this weekend.
Summary
These are required
https://docs.ansible.com/ansible/latest/collections/community/general/ipa_user_module.html#ansible-collections-community-general-ipa-user-module
Issue Type
Documentation Report
Component Name
ipa_user
Ansible Version
Community.general Version
Configuration
OS / Environment
Linux Mint 21.1
Additional Information
Code of Conduct