carpoon commented 9 months ago

Summary

In zfs, different properties can have different values, but there are two special ones, that require special handling, inherit and default. To achieve idempotency and to have the ability to set all values for zfs properties, it's required to handle these special values.

Issue Type

Feature Idea

Component Name

zfs

Additional Information

Why is it needed:

When a value is set, there's no way to set it back to the default value (default or inherit), you can set it to the same value, as the default, but it won't change with that value
we'd like to define many parameters for our zfs file systems and we have many values we'd like to leave as the default

The goal would be to a be able to write something like this:


- name: Create and set up a zfs filesystem
  zfs:
    name: "tank/example"
    state: present
    extra_zfs_properties:
      sync: "!default"
      compression: "!inherit"

Implementation details

For the module to be able to identify these special values, the '!' character is added to the values (this is not strictly needed, but in my opinion, with this, it's more distinctive and conveys the special use of these values)
To make this more maintainable, the user needs to know, it the zfs property has a default value or it can be inherited

If this behavior is acceptable, I'll create a PR with my modifications.