search

ansible-collections / community.general

Ansible Community General Collection
https://galaxy.ansible.com/ui/repo/published/community/general/
GNU General Public License v3.0
816 stars 1.5k forks source link

keycloak_clientscope: add normalizations for attributes and protocol_mappers #8496

Closed yeoldegrove closed 3 months ago

yeoldegrove commented 3 months ago
SUMMARY

keycloak_clientscope: Add sorted attributes and protocol_mappers to normalizations.

ISSUE TYPE
COMPONENT NAME

keycloak_clientscope

ADDITIONAL INFORMATION

Without this code, ansible-playbook --check --diffwill show changes because a unsorted list is diffed. It uses the same approach as for keycloak_client in https://github.com/ansible-collections/community.general/blob/6c8f949ba950309931d8931f4820b99707898850/plugins/modules/keycloak_client.py#L730

ansibullbot commented 3 months ago

cc @Gaetan2907 @eikef @mattock @ndclt click here for bot help

yeoldegrove commented 3 months ago

@felixfontein done

felixfontein commented 3 months ago

Thanks for your contribution! If nobody objects, I'll merge it on Sunday.

patchback[bot] commented 3 months ago

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/fd2cd5f28c7b2cc3b53f5366a94436a77f986dee/pr-8496

Backported as https://github.com/ansible-collections/community.general/pull/8520

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] commented 3 months ago

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/fd2cd5f28c7b2cc3b53f5366a94436a77f986dee/pr-8496

Backported as https://github.com/ansible-collections/community.general/pull/8521

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein commented 3 months ago

@yeoldegrove thanks for your contribution!