search

ansible-collections / community.general

Ansible Community General Collection
https://galaxy.ansible.com/ui/repo/published/community/general/
GNU General Public License v3.0
784 stars 1.45k forks source link

add test case for cmd_runner_fmt.as_list() #8541

Closed russoz closed 1 week ago

russoz commented 2 weeks ago
SUMMARY

Add testcase

ISSUE TYPE
COMPONENT NAME

plugins/module_utils/cmd_runner.py

patchback[bot] commented 1 week ago

Backport to stable-8: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 60ba7cab9390fbe19be5b4a967dd11de0fbae8c8 on top of patchback/backports/stable-8/60ba7cab9390fbe19be5b4a967dd11de0fbae8c8/pr-8541

Backporting merged PR #8541 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these instructions you'll refer to it by the name upstream. If you don't have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-8/60ba7cab9390fbe19be5b4a967dd11de0fbae8c8/pr-8541 upstream/stable-8
  4. Now, cherry-pick PR #8541 contents into that branch: 
    $ git cherry-pick -x 60ba7cab9390fbe19be5b4a967dd11de0fbae8c8

    If it'll yell at you with something like fatal: Commit 60ba7cab9390fbe19be5b4a967dd11de0fbae8c8 is a merge but no -m option was given., add -m 1 as follows instead:

    $ git cherry-pick -m1 -x 60ba7cab9390fbe19be5b4a967dd11de0fbae8c8
  5. At this point, you'll probably encounter some merge conflicts. You must resolve them in to preserve the patch from PR #8541 as close to the original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-8/60ba7cab9390fbe19be5b4a967dd11de0fbae8c8/pr-8541
  7. Create a PR, ensure that the CI is green. If it's not — update it so that the tests and any other checks pass. This is it! Now relax and wait for the maintainers to process your pull request when they have some cycles to do reviews. Don't worry — they'll tell you if any improvements are necessary when the time comes!

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

patchback[bot] commented 1 week ago

Backport to stable-9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-9/60ba7cab9390fbe19be5b4a967dd11de0fbae8c8/pr-8541

Backported as https://github.com/ansible-collections/community.general/pull/8547

🤖 @patchback I'm built with octomachinery and my source is open — https://github.com/sanitizers/patchback-github-app.

felixfontein commented 1 week ago

@russoz thanks!