ansible-collections / community.grafana

Grafana Collection for Ansible
http://galaxy.ansible.com/community/grafana
GNU General Public License v3.0
129 stars 82 forks source link

grafana_folder: fix grafana server empty response content #305

Closed pigay closed 11 months ago

pigay commented 1 year ago
SUMMARY

Handle empty response content from grafana API server.

ISSUE TYPE
COMPONENT NAME

grafana_folder

ADDITIONAL INFORMATION

Grafana API server appears to return empty content in some cases.

I encountered the problem when removing a folder (state: absent) with a grafana 9.3.6 server

codecov[bot] commented 1 year ago

Codecov Report

Merging #305 (d0c6517) into main (2202c99) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   74.59%   74.61%   +0.01%     
==========================================
  Files          14       14              
  Lines        1673     1674       +1     
  Branches      287      287              
==========================================
+ Hits         1248     1249       +1     
  Misses        285      285              
  Partials      140      140              
Flag Coverage Δ
integration 69.89% <100.00%> (+0.02%) :arrow_up:
units 65.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/grafana_folder.py 75.00% <100.00%> (+0.25%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rrey commented 11 months ago

I didn't see your PR and merge a patch that could have been yours ! sorry !