search

ansible-collections / community.grafana

Grafana Collection for Ansible
http://galaxy.ansible.com/community/grafana
GNU General Public License v3.0
123 stars 78 forks source link

test: replace deprecated TestCase.assertEquals #350

Closed bdrung closed 5 months ago

bdrung commented 5 months ago
SUMMARY

TestCase.assertEquals is depracated and removed in Python 3.12.

ISSUE TYPE
COMPONENT NAME

test

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6773070) 71.18% compared to head (c25dfb3) 71.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #350 +/- ## ======================================= Coverage 71.18% 71.18% ======================================= Files 18 18 Lines 1898 1898 Branches 332 332 ======================================= Hits 1351 1351 Misses 402 402 Partials 145 145 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `70.04% <ø> (ø)` | | | [sanity](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `23.22% <ø> (ø)` | | | [units](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `65.18% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rndmh3ro commented 5 months ago

Thanks!

Can you please add a changelog-fragment? Otherwise this PR is fine.

bdrung commented 5 months ago

Added changelogs/fragments/350-python3.12.yml (hopefully in the right format).