search

ansible-collections / community.grafana

Grafana Collection for Ansible
http://galaxy.ansible.com/community/grafana
GNU General Public License v3.0
123 stars 78 forks source link

feat: add module grafana_contact_point #352

Closed Nemental closed 1 month ago

Nemental commented 4 months ago
SUMMARY

New module for management of contact points, introduced with the new Grafana Unified Alerting in Grafana 8.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 73.21429% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 74.44%. Comparing base (101d40c) to head (9175486). Report is 14 commits behind head on main.

:exclamation: Current head 9175486 differs from pull request most recent head eff27c7

Please upload reports for the commit eff27c7 to get more accurate results.

Files Patch % Lines
plugins/modules/grafana_contact_point.py 73.21% 18 Missing and 12 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #352 +/- ## ========================================== + Coverage 72.00% 74.44% +2.43% ========================================== Files 20 15 -5 Lines 2097 1831 -266 Branches 356 340 -16 ========================================== - Hits 1510 1363 -147 + Misses 431 311 -120 - Partials 156 157 +1 ``` | [Flag](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/352/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/352/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `70.23% <72.32%> (-0.46%)` | :arrow_down: | | [sanity](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/352/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `?` | | | [units](https://app.codecov.io/gh/ansible-collections/community.grafana/pull/352/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections) | `65.18% <ø> (+1.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ansible-collections#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nemental commented 4 months ago

@rndmh3ro I don't think it's ready to merge but maybe it's time for a first review :) Maybe you have some time take a look. Next I want to do the documentation of the arguments in module file, so please ignore this for the moment :D

Nemental commented 1 month ago

@rndmh3ro finally ready to review 🎉 hopefully the tests are enough, I can't see it anymore 🫨