search

ansible-collections / community.grafana

Grafana Collection for Ansible
http://galaxy.ansible.com/community/grafana
GNU General Public License v3.0
123 stars 78 forks source link

fix: bump required ansible version to 2.15.0 #374

Closed Nemental closed 1 month ago

Nemental commented 1 month ago
SUMMARY

bump required ansible version to 2.15.0

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
rndmh3ro commented 1 month ago

Why exactly is 2.15 needed?

Nemental commented 1 month ago

@rndmh3ro https://github.com/ansible-collections/community.grafana/actions/runs/9302156010/job/25601790520#step:3:222 Or do you mean why not 2.16.0 because it's the official current version?

rndmh3ro commented 1 month ago

Thanks, I didn't know that ansible-lint also checks this now.. Don't know yet wether this is good or bad.

rndmh3ro commented 1 month ago

This rule seems rather controversial: https://github.com/ansible/ansible-lint/issues/3950

I'm fine with merging this, but I have to ask. Is removing support for an older ansible-version only a patch or rather a minor/major release? Idk.

Nemental commented 1 month ago

@rndmh3ro I think it's okay because it requires an already unmaintained version (2.15.0) anyway and not the official current version (2.16.0). Imo users should be aware that such issues may occur when using an unmaintained version.

Nemental commented 1 month ago

@rndmh3ro You're right, trivial doesn't fit in this case. Maybe we can go with breaking_changes as 2.0.0 is on the way? #375 Or just minor_changes...?

rndmh3ro commented 1 month ago

Well, if we release this with 2.0.0 I don't see a problem.