search

ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 61 forks source link

CI - set timeout on installing docker on macos #126

Closed briantist closed 3 years ago

briantist commented 3 years ago
SUMMARY

GHA's MacOS is pretty flaky and times vary for a lot of things. Installing Docker can take under 2 minutes or sometimes close to 5 minutes. Other times it seemingly hangs forever, waiting for an IP assignment or some other issue.

Let's set a timeout for that step to 6 minutes, so that it'll fail (relatively) quickly, and we can restart CI.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 3 years ago

Codecov Report

Merging #126 (15471cb) into main (4a64d4c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   85.76%   85.76%           
=======================================
  Files          29       29           
  Lines        1082     1082           
  Branches       83       83           
=======================================
  Hits          928      928           
  Misses        141      141           
  Partials       13       13
Flag Coverage Δ
env_docker-default 85.76% <ø> (ø)
integration 71.81% <ø> (ø)
py2.6 71.80% <ø> (ø)
py2.7 78.37% <ø> (ø)
py3.10 85.02% <ø> (ø)
py3.5 78.74% <ø> (ø)
py3.6 78.74% <ø> (ø)
py3.7 78.74% <ø> (ø)
py3.8 85.02% <ø> (ø)
py3.9 85.02% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_connection_options 73.78% <ø> (ø)
target_controller 67.98% <ø> (ø)
target_lookup_hashi_vault 78.75% <ø> (ø)
target_module_utils 81.60% <ø> (ø)
units 81.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64ec941...15471cb. Read the comment docs.

briantist commented 3 years ago

Well, ironically, we ran into the problem this aims to alleviate! https://github.com/ansible-collections/community.hashi_vault/pull/126/checks?check_run_id=3235915724

yay?