ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 61 forks source link

tests - move `jwt` and `approle` auth methods to their own integration targets, and add units #140

Closed briantist closed 3 years ago

briantist commented 3 years ago
SUMMARY

This finally gets all of the auth-method-specific stuff out of the hashi_vault lookup tests, drastically reducing the size and complexity of those tests. Unit tests are also added for those auth methods.

The next step (new PR(s)) is to add unit and integration tests for the 3 auth methods that are not tested at all: aws_iam_login, userpass, and ldap.

ISSUE TYPE
COMPONENT NAME

tests/

ADDITIONAL INFORMATION

N/A

codecov[bot] commented 3 years ago

Codecov Report

Merging #140 (2ab8561) into main (58fd38a) will increase coverage by 0.95%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   87.97%   88.93%   +0.95%     
==========================================
  Files          32       34       +2     
  Lines        1247     1346      +99     
  Branches       95      102       +7     
==========================================
+ Hits         1097     1197     +100     
  Misses        139      139              
+ Partials       11       10       -1     
Flag Coverage Δ
env_docker-default 88.93% <100.00%> (+0.95%) :arrow_up:
integration 71.13% <ø> (-1.05%) :arrow_down:
py2.6 34.78% <32.32%> (-0.25%) :arrow_down:
py2.7 80.31% <83.83%> (+0.36%) :arrow_up:
py3.10 87.89% <100.00%> (+1.04%) :arrow_up:
py3.5 80.60% <83.83%> (+0.33%) :arrow_up:
py3.6 80.60% <83.83%> (+0.33%) :arrow_up:
py3.7 80.60% <83.83%> (+0.33%) :arrow_up:
py3.8 87.89% <100.00%> (+1.04%) :arrow_up:
py3.9 87.89% <100.00%> (+1.04%) :arrow_up:
target_auth_approle 84.21% <ø> (?)
target_auth_jwt 86.95% <ø> (?)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.33% <ø> (ø)
target_connection_options 73.78% <ø> (ø)
target_controller 67.67% <ø> (ø)
target_lookup_hashi_vault 78.75% <ø> (ø)
target_module_utils 87.92% <100.00%> (+2.69%) :arrow_up:
units 86.62% <100.00%> (+2.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/module_utils/authentication/test_auth_approle.py 100.00% <100.00%> (ø)
...ugins/module_utils/authentication/test_auth_jwt.py 100.00% <100.00%> (ø)
plugins/module_utils/_auth_method_jwt.py 95.65% <0.00%> (+4.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 58fd38a...2ab8561. Read the comment docs.