briantist
commented
3 years ago https://github.com/ansible/ansible/pull/75605 has been merged, so this PR is no longer necessary.
As of now, CI still passes, but there are some TODOs for this collection that will be addressed in one or more other PRs:
- ensure all instances of the test modules (used in tests only) use
delegate_to: localhost-- they actually work as is, because they are used to talk to the running Vault server, and access works in docker and in a venv, from the target, but they really should be run on the controller alongside the Vault server. - the
auth_*andconnection_optionstargets don't have a clear context, so there are warnings about that; they will run on the target. That's the correct place to run them (they are module_utils) but let's providecontext/targetinaliasesto make it official (context/controlleris also possible, in case we ever need it explicitly). - will need to re-include additional python versions in devel CI, to properly cover supported target python versions again
- group controller vs target tests in
aliasesso that they can be invoked differently, and we can avoid invalid combinations like python versions that aren't supported on the controller, and/or specify different controller and target python versions - the action we use to pre-download docker images is broken in devel now. CI still works because that step is allowed to fail (
ansible-test's invocation will do it). This will remain broken untilansible-testhas the functionality built in, at which point we'll use the action for pre-2.12 versions of Ansible, and we'll use the built-in for devel/2.12+.
SUMMARY
DO NOT MERGE
This is running our tests using the split controller changes that are upcoming for
ansible-testto ensure our stuff still works and that we didn't make any bad assumptions about running on the controller.ISSUE TYPE
COMPONENT NAME
tests/integration
ADDITIONAL INFORMATION
See https://github.com/ansible/ansible/pull/75605