ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

update reqirements for 2.9 hcloud hvac conflict #145

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

hvac 0.11.1 upped the constraint for requests to be >= 2.25.1. That ends up conflicting with the constraints for hcloud which is pre-installed in the default test container in 2.9, causing ansible-test to throw an error and fail.

This PR declares hcloud in our requirements with a newer version. It's an unfortunate workaround, since we don't really need it at all.

Newer versions of the default container don't contain hcloud at all, but we'll be installing them in there anyway since we can't do this selectively.

ISSUE TYPE
COMPONENT NAME

tests/

ADDITIONAL INFORMATION

https://github.com/hvac/hvac/pull/741

codecov[bot] commented 2 years ago

Codecov Report

Merging #145 (aefd33c) into main (e78c74f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files          34       34           
  Lines        1346     1346           
  Branches      102      102           
=======================================
  Hits         1201     1201           
  Misses        135      135           
  Partials       10       10           
Flag Coverage Δ
env_docker-default 89.22% <ø> (ø)
integration 71.13% <ø> (ø)
py2.6 34.96% <ø> (ø)
py2.7 80.75% <ø> (ø)
py3.10 88.33% <ø> (ø)
py3.5 81.05% <ø> (ø)
py3.6 81.05% <ø> (ø)
py3.7 81.05% <ø> (ø)
py3.8 88.33% <ø> (ø)
py3.9 88.33% <ø> (ø)
sanity 34.95% <ø> (ø)
target_ansible-doc 35.75% <ø> (-0.41%) :arrow_down:
target_auth_approle 84.21% <ø> (ø)
target_auth_jwt 86.95% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.33% <ø> (ø)
target_connection_options 73.78% <ø> (ø)
target_controller 67.67% <ø> (ø)
target_import 34.26% <ø> (ø)
target_lookup_hashi_vault 78.75% <ø> (ø)
target_module_utils 87.92% <ø> (ø)
units 86.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e78c74f...aefd33c. Read the comment docs.