ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 61 forks source link

[DNM] redo - update reqirements for 2.9 hcloud hvac conflict #147

Closed briantist closed 2 years ago

briantist commented 3 years ago
SUMMARY

DO NOT MERGE

This is a re-do of #145 after it was reverted in #146

Opening this as it'll likely be needed, in some form, when hvac 1.0.0 is released.

Also consider: making it work only in CI: https://github.com/ansible-collections/community.routeros/pull/57

IF NEEDED AGAIN

Rebase first, this branch will be out of date.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 3 years ago

Codecov Report

Merging #147 (edba117) into main (e7b48b3) will decrease coverage by 5.58%. The diff coverage is n/a.

:exclamation: Current head edba117 differs from pull request most recent head f0e5e3a. Consider uploading reports for the commit f0e5e3a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   94.81%   89.22%   -5.59%     
==========================================
  Files          47       34      -13     
  Lines        1927     1346     -581     
  Branches      148      102      -46     
==========================================
- Hits         1827     1201     -626     
- Misses         85      135      +50     
+ Partials       15       10       -5     
Flag Coverage Δ
env_docker-default 89.22% <ø> (-5.59%) :arrow_down:
integration 71.13% <ø> (-9.35%) :arrow_down:
py2.6 34.96% <ø> (?)
py2.7 80.75% <ø> (?)
py3.10 88.33% <ø> (?)
py3.5 81.05% <ø> (?)
py3.6 81.05% <ø> (?)
py3.7 81.05% <ø> (?)
py3.8 88.33% <ø> (?)
py3.9 88.33% <ø> (?)
sanity 34.95% <ø> (-3.10%) :arrow_down:
target_ansible-doc 35.75% <ø> (-64.25%) :arrow_down:
target_auth_approle 84.21% <ø> (-5.27%) :arrow_down:
target_auth_aws_iam ?
target_auth_cert ?
target_auth_jwt 86.95% <ø> (-4.35%) :arrow_down:
target_auth_ldap ?
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.33% <ø> (+1.90%) :arrow_up:
target_auth_userpass ?
target_connection_options 73.78% <ø> (-0.98%) :arrow_down:
target_controller 67.67% <ø> (-1.58%) :arrow_down:
target_filter_vault_login_token ?
target_import 34.26% <ø> (-3.79%) :arrow_down:
target_lookup_hashi_vault 78.75% <ø> (-2.59%) :arrow_down:
target_lookup_vault_login ?
target_lookup_vault_read ?
target_module_utils 87.92% <ø> (-5.72%) :arrow_down:
target_module_vault_login ?
target_module_vault_read ?
units 86.62% <ø> (-5.54%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_auth_method_userpass.py 52.38% <0.00%> (-38.10%) :arrow_down:
plugins/module_utils/_auth_method_ldap.py 57.89% <0.00%> (-31.58%) :arrow_down:
...it/plugins/module_utils/authentication/conftest.py 92.00% <0.00%> (-8.00%) :arrow_down:
plugins/module_utils/_connection_options.py 92.23% <0.00%> (-0.30%) :arrow_down:
plugins/lookup/hashi_vault.py 83.75% <0.00%> (-0.25%) :arrow_down:
plugins/module_utils/_auth_method_token.py 97.77% <0.00%> (-0.19%) :arrow_down:
plugins/doc_fragments/auth.py 100.00% <0.00%> (ø)
plugins/doc_fragments/connection.py 100.00% <0.00%> (ø)
plugins/module_utils/_authenticator.py 100.00% <0.00%> (ø)
plugins/module_utils/_auth_method_jwt.py 95.65% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7822b4...f0e5e3a. Read the comment docs.

briantist commented 2 years ago

The expected 1.0.0 release of hvac has also not happened yet, but since this was a 2.9 thing, and we're not supporting 2.9 anymore this can be closed.

github-actions[bot] commented 2 years ago

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.