briantist commented 3 years ago

SUMMARY

Fixes missing and misconfigured docstrings; these changes should have been in #144

Luckily that PR's changes have not been released yet, otherwise it would have broken several options and auth methods.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

github-actions[bot] commented 3 years ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://community-hashi-vault-main.surge.sh

codecov[bot] commented 3 years ago

Codecov Report

Merging #153 (ebba04d) into main (61ba6ea) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ebba04d differs from pull request most recent head a27b69c. Consider uploading reports for the commit a27b69c to get more accurate results

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   89.24%   89.24%           
=======================================
  Files          34       34           
  Lines        1348     1348           
  Branches      102      102           
=======================================
  Hits         1203     1203           
  Misses        135      135           
  Partials       10       10

Flag	Coverage Δ
env_docker-default	`89.24% <ø> (ø)`
integration	`71.23% <ø> (ø)`
py2.6	`34.96% <ø> (ø)`
py2.7	`80.78% <ø> (ø)`
py3.10	`88.35% <ø> (ø)`
py3.5	`81.08% <ø> (ø)`
py3.6	`81.08% <ø> (ø)`
py3.7	`81.08% <ø> (ø)`
py3.8	`88.35% <ø> (ø)`
py3.9	`88.35% <ø> (ø)`
sanity	`35.18% <ø> (ø)`
target_ansible-doc	`36.01% <ø> (ø)`
target_auth_approle	`84.21% <ø> (ø)`
target_auth_jwt	`86.95% <ø> (ø)`
target_auth_none	`100.00% <ø> (ø)`
target_auth_token	`73.33% <ø> (ø)`
target_connection_options	`73.78% <ø> (ø)`
target_controller	`67.74% <ø> (ø)`
target_import	`34.48% <ø> (ø)`
target_lookup_hashi_vault	`78.75% <ø> (ø)`
target_module_utils	`87.92% <ø> (ø)`
units	`86.64% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugins/doc_fragments/auth.py	`100.00% <ø> (ø)`
plugins/lookup/hashi_vault.py	`83.75% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61ba6ea...a27b69c. Read the comment docs.

ansible-collections / community.hashi_vault

bug - docstrings missing and some with incorrect ini info #153