ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 61 forks source link

aws_auth - use session_token #161

Closed briantist closed 3 years ago

briantist commented 3 years ago
SUMMARY

Fixes #160

Also includes a basic unit test that would've caught this issue.

ISSUE TYPE
COMPONENT NAME

_auth_aws_iam_login

ADDITIONAL INFORMATION

N/A

codecov[bot] commented 3 years ago

Codecov Report

Merging #161 (4d3feb0) into main (1168870) will increase coverage by 1.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   89.56%   90.83%   +1.26%     
==========================================
  Files          35       36       +1     
  Lines        1399     1440      +41     
  Branches      105      111       +6     
==========================================
+ Hits         1253     1308      +55     
+ Misses        135      120      -15     
- Partials       11       12       +1     
Flag Coverage Δ
env_docker-default 90.83% <100.00%> (+1.26%) :arrow_up:
integration 73.00% <0.00%> (-0.36%) :arrow_down:
py2.6 35.13% <39.02%> (+0.13%) :arrow_up:
py2.7 82.15% <85.36%> (+1.09%) :arrow_up:
py3.10 89.93% <100.00%> (+1.29%) :arrow_up:
py3.5 82.43% <85.36%> (+1.08%) :arrow_up:
py3.6 82.43% <85.36%> (+1.08%) :arrow_up:
py3.7 82.43% <85.36%> (+1.08%) :arrow_up:
py3.8 89.93% <100.00%> (+1.29%) :arrow_up:
py3.9 89.93% <100.00%> (+1.29%) :arrow_up:
sanity 34.95% <0.00%> (-0.18%) :arrow_down:
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 67.31% <0.00%> (-0.24%) :arrow_down:
target_import 34.95% <0.00%> (-0.18%) :arrow_down:
target_lookup_hashi_vault 79.72% <ø> (ø)
target_module_utils 89.84% <100.00%> (+1.60%) :arrow_up:
units 88.23% <100.00%> (+1.37%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_auth_method_aws_iam_login.py 51.85% <100.00%> (+30.28%) :arrow_up:
...le_utils/authentication/test_auth_aws_iam_login.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1168870...4d3feb0. Read the comment docs.

briantist commented 3 years ago

Also confirmed with a colleague (who first brought this to my attention) that this patch is working, so feel pretty comfortable with it.