horazont commented 2 years ago

SUMMARY

This makes most sense; it is part of the credentials needed to authenticate with vault, e.g. on servers with multiple independent AppRole mountpoints.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

auth methods

ADDITIONAL INFORMATION

Hopefully self-explanatory, if it is not, please let me know.

briantist commented 2 years ago

Hello @horazont and welcome! Thanks for submitting this. Please also add a changelog fragment in the format described. You may use auth methods for the scope portion, and the link at the end can point at this PR.

codecov[bot] commented 2 years ago

Codecov Report

Merging #171 (2c6a957) into main (af71153) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          40       40           
  Lines        1587     1587           
  Branches      123      123           
=======================================
  Hits         1455     1455           
  Misses        119      119           
  Partials       13       13

Flag	Coverage Δ
env_docker-default	`91.68% <ø> (ø)`
integration	`75.80% <ø> (ø)`
py2.6	`36.18% <ø> (ø)`
py2.7	`83.49% <ø> (ø)`
py3.10	`90.80% <ø> (ø)`
py3.5	`83.74% <ø> (ø)`
py3.6	`83.74% <ø> (ø)`
py3.7	`83.74% <ø> (ø)`
py3.8	`90.86% <ø> (ø)`
py3.9	`90.86% <ø> (ø)`
sanity	`37.76% <ø> (ø)`
target_ansible-doc	`100.00% <ø> (ø)`
target_auth_approle	`89.47% <ø> (ø)`
target_auth_cert	`56.40% <ø> (ø)`
target_auth_jwt	`91.30% <ø> (ø)`
target_auth_none	`100.00% <ø> (ø)`
target_auth_token	`71.42% <ø> (ø)`
target_connection_options	`74.76% <ø> (ø)`
target_controller	`67.00% <ø> (ø)`
target_import	`37.76% <ø> (ø)`
target_lookup_hashi_vault	`81.33% <ø> (ø)`
target_lookup_vault_read	`90.00% <ø> (ø)`
target_module_utils	`90.40% <ø> (ø)`
target_module_vault_read	`92.10% <ø> (ø)`
units	`88.78% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
plugins/doc_fragments/auth.py	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af71153...2c6a957. Read the comment docs.

horazont commented 2 years ago

Hi @briantist. Sorry for the late reaction, GitHub email notifications aren't reliable for me because they end up in my private inbox instead of my work inbox for this.

Anyway, am I doing this right? :)

briantist commented 2 years ago

@horazont please also rebase your branch against the upstream main, as I fixed the issue with the macos CI job failing.

github-actions[bot] commented 2 years ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://community-hashi-vault-main.surge.sh

ansible-collections / community.hashi_vault

auth: add env and ini var for mount_point option #171