search

ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

connection options - make `url` required and remove the default value #176

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Resolves: #83

ISSUE TYPE
COMPONENT NAME

connection_options

ADDITIONAL INFORMATION

N/A

codecov[bot] commented 2 years ago

Codecov Report

Merging #176 (457a1c5) into main (af71153) will increase coverage by 0.03%. The diff coverage is 100.00%.

:exclamation: Current head 457a1c5 differs from pull request most recent head 5b6be9e. Consider uploading reports for the commit 5b6be9e to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   91.68%   91.71%   +0.03%     
==========================================
  Files          40       40              
  Lines        1587     1593       +6     
  Branches      123      124       +1     
==========================================
+ Hits         1455     1461       +6     
  Misses        119      119              
  Partials       13       13
Flag Coverage Δ
env_docker-default 91.71% <100.00%> (+0.03%) :arrow_up:
integration 75.59% <0.00%> (-0.22%) :arrow_down:
py2.6 36.10% <16.66%> (-0.09%) :arrow_down:
py2.7 83.55% <100.00%> (+0.06%) :arrow_up:
py3.10 90.83% <100.00%> (+0.03%) :arrow_up:
py3.5 83.80% <100.00%> (+0.06%) :arrow_up:
py3.6 83.80% <100.00%> (+0.06%) :arrow_up:
py3.7 83.80% <100.00%> (+0.06%) :arrow_up:
py3.8 90.89% <100.00%> (+0.03%) :arrow_up:
py3.9 90.89% <100.00%> (+0.03%) :arrow_up:
sanity 37.65% <0.00%> (-0.11%) :arrow_down:
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 56.20% <0.00%> (-0.21%) :arrow_down:
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 66.62% <0.00%> (-0.38%) :arrow_down:
target_import 37.65% <0.00%> (-0.11%) :arrow_down:
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.44% <100.00%> (+0.04%) :arrow_up:
target_module_vault_read 92.10% <ø> (ø)
units 88.82% <100.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/connection.py 100.00% <ø> (ø)
plugins/module_utils/_connection_options.py 92.52% <ø> (ø)
tests/unit/plugins/lookup/test_hashi_vault.py 100.00% <ø> (ø)
plugins/module_utils/_hashi_vault_common.py 100.00% <100.00%> (ø)
...odule_utils/test_hashi_vault_connection_options.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af71153...5b6be9e. Read the comment docs.

github-actions[bot] commented 2 years ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://community-hashi-vault-main.surge.sh