ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

Drop support for Python 2 & 3.5 #177

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Remove explicit support for Python 2.7 and 3.5 (2.6 was already unsupported).

Resolves: #81

Not looking to explicitly break anything in those python versions, but we won't be testing against it or enforcing support in PRs. We may accept PRs that look to make something that stopped working, work again in an unsupported python version, if the change is not regressive or otherwise looks reasonable. It will be a case by case basis.

ISSUE TYPE
COMPONENT NAME

N/A

ADDITIONAL INFORMATION

N/A

codecov[bot] commented 2 years ago

Codecov Report

Merging #177 (b6cb19c) into main (af71153) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
- Coverage   91.68%   91.66%   -0.03%     
==========================================
  Files          40       40              
  Lines        1587     1583       -4     
  Branches      123      121       -2     
==========================================
- Hits         1455     1451       -4     
  Misses        119      119              
  Partials       13       13              
Flag Coverage Δ
env_docker-default 91.66% <100.00%> (-0.03%) :arrow_down:
integration 75.80% <ø> (ø)
py2.6 36.14% <33.33%> (-0.05%) :arrow_down:
py2.7 54.70% <33.33%> (-28.79%) :arrow_down:
py3.10 90.90% <33.33%> (+0.10%) :arrow_up:
py3.5 54.57% <33.33%> (-29.17%) :arrow_down:
py3.6 83.82% <33.33%> (+0.08%) :arrow_up:
py3.7 83.82% <33.33%> (+0.08%) :arrow_up:
py3.8 90.96% <33.33%> (+0.10%) :arrow_up:
py3.9 90.96% <33.33%> (+0.10%) :arrow_up:
sanity 37.76% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_cert 56.40% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 67.00% <0.00%> (ø)
target_import 37.76% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_module_utils 90.12% <33.33%> (-0.28%) :arrow_down:
target_module_vault_read 92.10% <ø> (ø)
units 88.75% <100.00%> (-0.04%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...it/plugins/module_utils/test_hashi_vault_helper.py 100.00% <ø> (ø)
tests/unit/conftest.py 100.00% <100.00%> (ø)
...s/authentication/test_hashi_vault_authenticator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af71153...b6cb19c. Read the comment docs.

felixfontein commented 2 years ago

recheck