github-actions[bot]
commented
2 years ago Docs Build 📝
Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh
Closed briantist closed 2 years ago
github-actions[bot]
commented
2 years ago Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://community-hashi-vault-main.surge.sh
codecov[bot]
commented
2 years ago Merging #191 (90737f3) into main (d46c544) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## main #191 +/- ##
=======================================
Coverage 91.69% 91.69%
=======================================
Files 40 40
Lines 1589 1589
Branches 122 122
=======================================
Hits 1457 1457
Misses 119 119
Partials 13 13 | Flag | Coverage Δ | |
|---|---|---|
| env_docker-default | 91.69% <ø> (ø) |
|
| integration | 75.59% <ø> (ø) |
|
| sanity | 37.65% <ø> (ø) |
|
| target_ansible-doc | 100.00% <ø> (ø) |
|
| target_auth_approle | 89.47% <ø> (ø) |
|
| target_auth_cert | 86.36% <ø> (ø) |
|
| target_auth_jwt | 91.30% <ø> (ø) |
|
| target_auth_none | 100.00% <ø> (ø) |
|
| target_auth_token | 71.42% <ø> (ø) |
|
| target_connection_options | 74.76% <ø> (ø) |
|
| target_controller | 66.62% <ø> (ø) |
|
| target_import | 37.65% <ø> (ø) |
|
| target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
| target_lookup_vault_read | 90.00% <ø> (ø) |
|
| target_module_utils | 90.17% <ø> (ø) |
|
| target_module_vault_read | 92.10% <ø> (ø) |
|
| units | 88.79% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update d46c544...90737f3. Read the comment docs.
SUMMARY
This PR removes the "legacy" integration test option, that downloaded Vault and tinyproxy locally.
It provided ease of use, where contributors could simply rename the sample integration config and run tests, but it was very slow if you needed to run multiple targets. It's also tough to maintain.
I want to introduce additional software needed, such as MMock, an additional Vault instance or two (Agent mode, perhaps a separate writable instance), toxiproxy, possible an LDAP server, etc. Every one of these would require additional direct install support to continue supporting the legacy mode.
The docker-based localenv is much simpler to add additional software onto, as it's just a matter of additional containers to the config.
This PR also:
ISSUE TYPE
COMPONENT NAME
tests/CI
ADDITIONAL INFORMATION