codecov[bot]
commented
2 years ago Codecov Report
Merging #196 (2d04377) into main (8c075fb) will increase coverage by
0.51%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #196 +/- ##
==========================================
+ Coverage 93.96% 94.47% +0.51%
==========================================
Files 41 42 +1
Lines 1739 1792 +53
Branches 135 140 +5
==========================================
+ Hits 1634 1693 +59
+ Misses 91 85 -6
Partials 14 14 | Flag | Coverage Δ | |
|---|---|---|
| env_docker-default | 94.47% <100.00%> (+0.51%) |
:arrow_up: |
| integration | 79.19% <ø> (+0.83%) |
:arrow_up: |
| sanity | 37.44% <ø> (ø) |
|
| target_ansible-doc | 100.00% <ø> (ø) |
|
| target_auth_approle | 89.47% <ø> (ø) |
|
| target_auth_aws_iam | 50.00% <ø> (ø) |
|
| target_auth_cert | 86.36% <ø> (ø) |
|
| target_auth_jwt | 91.30% <ø> (ø) |
|
| target_auth_ldap | 89.47% <ø> (?) |
|
| target_auth_none | 100.00% <ø> (ø) |
|
| target_auth_token | 71.42% <ø> (ø) |
|
| target_auth_userpass | 85.71% <ø> (ø) |
|
| target_connection_options | 74.76% <ø> (ø) |
|
| target_controller | 66.44% <ø> (ø) |
|
| target_import | 37.44% <ø> (ø) |
|
| target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
| target_lookup_vault_read | 90.00% <ø> (ø) |
|
| target_module_utils | 93.63% <100.00%> (+0.60%) |
:arrow_up: |
| target_module_vault_read | 92.10% <ø> (ø) |
|
| units | 91.92% <100.00%> (+0.56%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...gins/module_utils/authentication/test_auth_ldap.py | 100.00% <100.00%> (ø) |
|
| plugins/module_utils/_auth_method_ldap.py | 89.47% <0.00%> (+31.57%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 8c075fb...2d04377. Read the comment docs.
briantist
SUMMARY
Fixes #117
Adds unit and integration tests for the
ldapauth method.ISSUE TYPE
COMPONENT NAME
tests/
ADDITIONAL INFORMATION
There have never been tests for
ldapauth method; with the addition of MMock in #193 , we can test this in a similar way, mocking the result from Vault without having to set up an LDAP server.