Closed briantist closed 2 years ago
Merging #221 (7be043e) into main (1595222) will increase coverage by
2.24%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 94.67% 96.92% +2.24%
==========================================
Files 50 45 -5
Lines 2085 1919 -166
Branches 162 144 -18
==========================================
- Hits 1974 1860 -114
+ Misses 90 45 -45
+ Partials 21 14 -7
Flag | Coverage Δ | |
---|---|---|
env_docker-default | 96.92% <ø> (+2.24%) |
:arrow_up: |
integration | 80.35% <ø> (ø) |
|
sanity | 38.69% <ø> (ø) |
|
target_ansible-doc | 100.00% <ø> (ø) |
|
target_auth_approle | 89.47% <ø> (ø) |
|
target_auth_aws_iam | 50.00% <ø> (ø) |
|
target_auth_cert | 86.36% <ø> (ø) |
|
target_auth_jwt | 91.30% <ø> (ø) |
|
target_auth_ldap | 89.47% <ø> (ø) |
|
target_auth_none | 100.00% <ø> (ø) |
|
target_auth_token | 71.42% <ø> (ø) |
|
target_auth_userpass | 85.71% <ø> (ø) |
|
target_connection_options | 74.76% <ø> (ø) |
|
target_controller | 71.80% <ø> (+2.55%) |
:arrow_up: |
target_filter_vault_login_token | 77.77% <ø> (ø) |
|
target_import | 38.69% <ø> (ø) |
|
target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
target_lookup_vault_login | 100.00% <ø> (ø) |
|
target_lookup_vault_read | 90.00% <ø> (ø) |
|
target_module_utils | 96.72% <ø> (+3.09%) |
:arrow_up: |
target_module_vault_login | 93.93% <ø> (ø) |
|
target_module_vault_pki_generate_certificate | 78.26% <ø> (ø) |
|
target_module_vault_read | 92.10% <ø> (ø) |
|
target_modules | 57.92% <ø> (+1.93%) |
:arrow_up: |
units | 93.86% <ø> (+2.11%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1595222...7be043e. Read the comment docs.
Confirmed: changing this file alone raised coverage, without any other files being changed. This also answers the question of whether codecov uses the yml file in the diff in calculating diff coverage, and it seems that it does!
SUMMARY
I think I've been using the wrong paths for the ignore section, I was trying to start them with
**/
but since the paths started in the root, I think the path fixing was trimming off the beginnings (like it was supposed to), and so the/
part was causing them not to match... trying to see if this works.ISSUE TYPE
COMPONENT NAME
n/a
ADDITIONAL INFORMATION
n/a