ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

change CI to test Vault versions in ascending order #225

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

https://github.com/ansible-collections/community.hashi_vault/blob/40eeaa57785ed4b054b6e16c5c8106ef11ddc4ba/.github/workflows/ansible-test.yml#L255-L279

Vault versions under test are given to us in descending order (newest first), and we test them in that order as well, but it might be better to test older versions first.

Presumably, tests were working for older versions before, so if tests are broken now, they will fail on the newer version and never run on the older version.

Instead, if we run on an older version first, then we see that it failed on the older version (better indication that the problem is in the tests), or if it passes on older and fails on newer, we can look at what changed.


This should be as easy as changing the indices in the linked workflow to do [1] before [0].

ISSUE TYPE
COMPONENT NAME

ansible-test workflow

ADDITIONAL INFORMATION