adding wrapping functionality to any plugins and modules where it makes sense

[briantist]

SUMMARY

223 introduces a doc fragment wrapping.py for the wrap_ttl option.

This option and the resulting functionality should be added to any plugins and modules where it could be valid, which is nearly anything that returns data.

All modified content must include tests for this as well.

Current list of candidates:

• vault_read (module and lookup)
• vault_login (module and lookup), this will also require central changes to the authenticator and to each auth method's module util, but should be doable

ISSUE TYPE

• Feature Idea

COMPONENT NAME

ADDITIONAL INFORMATION

[lpkirby]

Hi @briantist I've started doing this here: https://github.com/lpkirby/community.hashi_vault/tree/228_add_wrap_ttl But I didn't want to duplicate work if you've already start working on this. So I'll stop if you're actively working on it.

[briantist]

Hi @lpkirby ! Thank you for asking. I'm not currently working on this, so please proceed and open a PR when you're ready (it doesn't have to be "done" to open a PR).

Looking at the changes you have on your fork, I'll point out that there's already a doc fragment for the parameter, so you can reference that instead of specifying it directly: https://github.com/ansible-collections/community.hashi_vault/blob/main/plugins/doc_fragments/wrapping.py

If you haven't already, please also see the Contributor guide.

Finally, referring to #223 may give you some ideas for implementing the tests.

Thanks again for looking to contribute!