Closed briantist closed 2 years ago
Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main
:
https://ansible-collections.github.io/community.hashi_vault/branch/main
I'm also going to add a link to this guide in the seealso:
section of the hashi_vault
lookup but I'm going to wait until it's ready to merge, because that change will trigger the full CI to run, and I want to avoid that when fixing up typos and stuff in the guide.
Merging #249 (7026272) into main (54c81ef) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #249 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 66 66
Lines 3208 3208
Branches 267 267
=======================================
Hits 3155 3155
Misses 44 44
Partials 9 9
Flag | Coverage Δ | |
---|---|---|
env_docker-default | 98.34% <ø> (ø) |
|
integration | 81.03% <ø> (ø) |
|
sanity | 39.88% <ø> (ø) |
|
target_ansible-doc | 100.00% <ø> (ø) |
|
target_auth_approle | 89.47% <ø> (ø) |
|
target_auth_aws_iam | 50.00% <ø> (ø) |
|
target_auth_cert | 86.36% <ø> (ø) |
|
target_auth_jwt | 91.30% <ø> (ø) |
|
target_auth_ldap | 89.47% <ø> (ø) |
|
target_auth_none | 100.00% <ø> (ø) |
|
target_auth_token | 71.42% <ø> (ø) |
|
target_auth_userpass | 85.71% <ø> (ø) |
|
target_connection_options | 74.76% <ø> (ø) |
|
target_controller | 80.84% <ø> (ø) |
|
target_filter_vault_login_token | 77.77% <ø> (ø) |
|
target_import | 39.88% <ø> (ø) |
|
target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
target_lookup_vault_kv1_get | 91.30% <ø> (ø) |
|
target_lookup_vault_kv2_get | 91.11% <ø> (ø) |
|
target_lookup_vault_login | 88.57% <ø> (ø) |
|
target_lookup_vault_read | 90.00% <ø> (ø) |
|
target_lookup_vault_token_create | 78.18% <ø> (ø) |
|
target_lookup_vault_write | 59.14% <ø> (ø) |
|
target_module_utils | 97.24% <ø> (ø) |
|
target_module_vault_kv1_get | 87.23% <ø> (ø) |
|
target_module_vault_kv2_get | 86.95% <ø> (ø) |
|
target_module_vault_login | 83.33% <ø> (ø) |
|
target_module_vault_pki_generate_certificate | 78.26% <ø> (ø) |
|
target_module_vault_read | 85.36% <ø> (ø) |
|
target_module_vault_token_create | 90.00% <ø> (ø) |
|
target_module_vault_write | 57.53% <ø> (ø) |
|
target_modules | 79.08% <ø> (ø) |
|
units | 95.26% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
plugins/lookup/hashi_vault.py | 84.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 54c81ef...7026272. Read the comment docs.
thanks again for another review @felixfontein !
SUMMARY
This will require (it will contain RST references to those plugins):
246
With the KV read content, we have full coverage of the functionality that
community.hashi_vault.hashi_vault
provided, and I can write a complete guide for making use of the newer content.ISSUE TYPE