Tests/fill in

[briantist]

SUMMARY

Fixes: #257 Fixes: #214

Also:

• move some duplicated lookup unit test stuff to conftest.py
• add units for vault_login module
• removed unnecessary copy/pasted mocks and fixtures in module hvac checking in units
• move a few more thing around in units and get a little more coverage
• ignore unit root conftest.py

ISSUE TYPE

• Bugfix Pull Request

[codecov[bot]]

Codecov Report

Merging #259 (74de514) into main (c4b8b82) will increase coverage by 0.40%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   97.94%   98.34%   +0.40%     
==========================================
  Files          65       66       +1     
  Lines        3060     3208     +148     
  Branches      268      267       -1     
==========================================
+ Hits         2997     3155     +158     
+ Misses         49       44       -5     
+ Partials       14        9       -5     

Flag	Coverage Δ
env_docker-default	98.34% <100.00%> (+0.40%)	:arrow_up:
integration	81.03% <44.44%> (-0.87%)	:arrow_down:
sanity	39.88% <58.33%> (+0.46%)	:arrow_up:
target_ansible-doc	100.00% <ø> (ø)
target_auth_approle	89.47% <ø> (ø)
target_auth_aws_iam	50.00% <ø> (ø)
target_auth_cert	86.36% <ø> (ø)
target_auth_jwt	91.30% <ø> (ø)
target_auth_ldap	89.47% <ø> (ø)
target_auth_none	100.00% <ø> (ø)
target_auth_token	71.42% <ø> (ø)
target_auth_userpass	85.71% <ø> (ø)
target_connection_options	74.76% <ø> (ø)
target_controller	80.84% <93.33%> (+1.52%)	:arrow_up:
target_filter_vault_login_token	77.77% <ø> (ø)
target_import	39.88% <58.33%> (+0.46%)	:arrow_up:
target_lookup_hashi_vault	81.33% <ø> (ø)
target_lookup_vault_kv1_get	91.30% <ø> (ø)
target_lookup_vault_kv2_get	91.11% <ø> (ø)
target_lookup_vault_login	88.57% <50.00%> (-11.43%)	:arrow_down:
target_lookup_vault_read	90.00% <33.33%> (ø)
target_lookup_vault_token_create	78.18% <50.00%> (-4.80%)	:arrow_down:
target_lookup_vault_write	59.14% <33.33%> (ø)
target_module_utils	97.24% <100.00%> (+1.33%)	:arrow_up:
target_module_vault_kv1_get	87.23% <ø> (ø)
target_module_vault_kv2_get	86.95% <ø> (ø)
target_module_vault_login	83.33% <44.44%> (-10.61%)	:arrow_down:
target_module_vault_pki_generate_certificate	78.26% <ø> (ø)
target_module_vault_read	85.36% <40.00%> (-6.74%)	:arrow_down:
target_module_vault_token_create	90.00% <ø> (ø)
target_module_vault_write	57.53% <ø> (ø)
target_modules	79.08% <97.74%> (+2.94%)	:arrow_up:
units	95.26% <97.76%> (+0.84%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
tests/unit/plugins/lookup/test_vault_kv1_get.py	100.00% <ø> (ø)
tests/unit/plugins/lookup/test_vault_kv2_get.py	100.00% <ø> (ø)
tests/unit/plugins/lookup/test_vault_write.py	100.00% <ø> (ø)
plugins/lookup/vault_login.py	100.00% <100.00%> (ø)
plugins/lookup/vault_read.py	100.00% <100.00%> (+5.00%)	:arrow_up:
plugins/lookup/vault_token_create.py	96.36% <100.00%> (+0.61%)	:arrow_up:
plugins/modules/vault_login.py	100.00% <100.00%> (+3.03%)	:arrow_up:
plugins/modules/vault_read.py	100.00% <100.00%> (ø)
tests/unit/plugins/lookup/test_vault_login.py	100.00% <100.00%> (ø)
tests/unit/plugins/lookup/test_vault_read.py	100.00% <100.00%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4b8b82...74de514. Read the comment docs.