ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

Collection violates Ansible Community Package licensing guidelines #276

Closed gotmax23 closed 2 years ago

gotmax23 commented 2 years ago

https://github.com/ansible-collections/community.hashi_vault/blob/8c0fc19d125d4e979888be2c11e8a6d3c67de94d/plugins/plugin_utils/_hashi_vault_lookup_base.py#L2-L3

According to the Ansible Community Package licensing guidelines: "All other code [i.e. not modules or module_utils] must be under the GPL-3.0-or-later. These plugins are run inside of the Ansible controller process which is licensed under the GPLv3+ and often must import code from the controller. For these reasons, the GPLv3+ must be used."

See https://github.com/ansible-collections/overview/blob/main/collection_requirements.rst#id7 for more information. I'm not sure what is the procedure to rectify this, but I noticed it while preforming a license review for the Fedora ansible package and figured I'd point it out. It looks like @briantist is the only copyright owner/commiter, so I guess they'd have to relicense the file in question.

briantist commented 2 years ago

Thanks @gotmax23 , I think that was just an oversight from splitting off of a module_util. I'll likely fix this at the same time as #275 which is another licensing related thing I need to fix.