ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

License fixes (part 2) #282

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Related:

This is part 2 of what's implemented in #280 . It fixes the headers in existing files, and adds SPDX headers.

It already includes those changes and will be rebased after #280 is merged.

The commit created by this PR being merged will be added to a new .git-blame-ignore-revs file.

~After #280 is merged and this is rebased, I may try adding the ignore revs file in the same PR, and using the "Rebase and merge" option instead of "Squash and merge"; I think that will preserve the original commit hash of the one I want to ignore, and put both commits in main. If it doesn't work right, I can always fix it after.~

From the docs:

The rebase and merge behavior on GitHub deviates slightly from git rebase. Rebase and merge on GitHub will always update the committer information and create new commit SHAs, whereas git rebase outside of GitHub does not change the committer information when the rebase happens on top of an ancestor commit.

And some more discussion about the feature on SO.

ISSUE TYPE
codecov[bot] commented 2 years ago

Codecov Report

Merging #282 (4018695) into main (a35e33f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          68       68           
  Lines        3343     3343           
  Branches      290      290           
=======================================
  Hits         3290     3290           
  Misses         44       44           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.41% <ø> (ø)
integration 81.86% <ø> (ø)
sanity 39.27% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.07% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 82.47% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.27% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 57.10% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.66% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 78.18% <ø> (ø)
target_lookup_vault_write 59.24% <ø> (ø)
target_module_utils 97.02% <ø> (ø)
target_module_vault_kv1_get 87.23% <ø> (ø)
target_module_vault_kv2_get 86.95% <ø> (ø)
target_module_vault_login 83.33% <ø> (ø)
target_module_vault_pki_generate_certificate 78.26% <ø> (ø)
target_module_vault_read 85.36% <ø> (ø)
target_module_vault_token_create 90.00% <ø> (ø)
target_module_vault_write 58.19% <ø> (ø)
target_modules 79.06% <ø> (ø)
units 95.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/doc_fragments/auth.py 100.00% <ø> (ø)
plugins/doc_fragments/connection.py 100.00% <ø> (ø)
plugins/doc_fragments/engine_mount.py 100.00% <ø> (ø)
plugins/doc_fragments/token_create.py 100.00% <ø> (ø)
plugins/doc_fragments/wrapping.py 100.00% <ø> (ø)
plugins/filter/vault_login_token.py 100.00% <ø> (ø)
plugins/lookup/hashi_vault.py 84.00% <ø> (ø)
plugins/lookup/vault_ansible_settings.py 100.00% <ø> (ø)
plugins/lookup/vault_kv1_get.py 100.00% <ø> (ø)
plugins/lookup/vault_kv2_get.py 100.00% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a35e33f...4018695. Read the comment docs.

briantist commented 2 years ago

@felixfontein thanks again for reviewing, and for the script to put these headers in place