ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

Add HTTP `412` to default retry list #292

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Resolves #290

Retry on HTTP status 412 for Server Side Consistent Token feature in Vault Enterprise.

ISSUE TYPE
COMPONENT NAME

_connection_options

ADDITIONAL INFORMATION

See:

Slightly related:

github-actions[bot] commented 2 years ago

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main: https://ansible-collections.github.io/community.hashi_vault/branch/main

codecov[bot] commented 2 years ago

Codecov Report

Merging #292 (47b1703) into main (3c1e1fa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #292   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          71       71           
  Lines        3458     3458           
  Branches      301      301           
=======================================
  Hits         3405     3405           
  Misses         44       44           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.46% <ø> (ø)
integration 81.62% <ø> (ø)
sanity 39.28% <ø> (ø)
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.07% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.67% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.28% <ø> (ø)
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 57.16% <ø> (ø)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.66% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 78.18% <ø> (ø)
target_lookup_vault_write 59.26% <ø> (ø)
target_module_utils 96.71% <ø> (ø)
target_module_vault_kv1_get 87.23% <ø> (ø)
target_module_vault_kv2_get 86.95% <ø> (ø)
target_module_vault_login 83.33% <ø> (ø)
target_module_vault_pki_generate_certificate 78.26% <ø> (ø)
target_module_vault_read 85.36% <ø> (ø)
target_module_vault_token_create 90.00% <ø> (ø)
target_module_vault_write 58.24% <ø> (ø)
target_modules 78.66% <ø> (ø)
units 95.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/module_utils/_connection_options.py 92.52% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

briantist commented 2 years ago

thanks for reviewing this one as well @felixfontein !