ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

Sanity/use before assignment #297

Closed briantist closed 2 years ago

briantist commented 2 years ago
SUMMARY

Fixes #296

ISSUE TYPE
COMPONENT NAME

modules

codecov[bot] commented 2 years ago

Codecov Report

Merging #297 (1b8ed12) into main (f036ced) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          71       71           
  Lines        3458     3464    +6     
  Branches      301      301           
=======================================
+ Hits         3405     3411    +6     
  Misses         44       44           
  Partials        9        9           
Flag Coverage Δ
env_docker-default 98.46% <100.00%> (+<0.01%) :arrow_up:
integration 81.70% <100.00%> (+0.08%) :arrow_up:
sanity 39.11% <0.00%> (-0.18%) :arrow_down:
target_ansible-doc 100.00% <ø> (ø)
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 73.07% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.67% <ø> (ø)
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.11% <0.00%> (-0.18%) :arrow_down:
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 57.21% <100.00%> (+0.05%) :arrow_up:
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.66% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 78.18% <ø> (ø)
target_lookup_vault_write 59.26% <ø> (ø)
target_module_utils 96.71% <ø> (ø)
target_module_vault_kv1_get 87.50% <100.00%> (+0.26%) :arrow_up:
target_module_vault_kv2_get 87.23% <100.00%> (+0.27%) :arrow_up:
target_module_vault_login 83.72% <100.00%> (+0.38%) :arrow_up:
target_module_vault_pki_generate_certificate 78.72% <100.00%> (+0.46%) :arrow_up:
target_module_vault_read 85.71% <100.00%> (+0.34%) :arrow_up:
target_module_vault_token_create 90.00% <ø> (ø)
target_module_vault_write 58.31% <100.00%> (+0.07%) :arrow_up:
target_modules 78.75% <100.00%> (+0.08%) :arrow_up:
units 95.61% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/modules/vault_kv1_get.py 100.00% <100.00%> (ø)
plugins/modules/vault_kv2_get.py 100.00% <100.00%> (ø)
plugins/modules/vault_login.py 100.00% <100.00%> (ø)
plugins/modules/vault_pki_generate_certificate.py 95.74% <100.00%> (+0.09%) :arrow_up:
plugins/modules/vault_read.py 100.00% <100.00%> (ø)
plugins/modules/vault_write.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

briantist commented 2 years ago

@felixfontein thanks for reviewing!