search

ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

Add vault_login_token filter docs #302

Closed felixfontein closed 1 year ago

felixfontein commented 1 year ago
SUMMARY

Right now the only filter in this collection is not documented, resulting in https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/vault_login_token_filter.html. Let's fix that :)

ISSUE TYPE
COMPONENT NAME

vault_login_token

felixfontein commented 1 year ago

The remaining errors seem to be unrelated to this PR.

briantist commented 1 year ago

Thanks for opening this @felixfontein ! I had started this back in #263 , but had issues with the support in core and how references to the page would work in the docsite (see comments there), which is why I didn't end up merging it.

Perhaps somewhat similarly, the docs build does not seem to have picked up the changes in this PR (no build comment showing changes).

(the other failures are not related to this, they are due to hvac==1.0.0 being released last night and will be resolved soon, see #301)

felixfontein commented 1 year ago

Perhaps somewhat similarly, the docs build does not seem to have picked up the changes in this PR (no build comment showing changes).

Which is not surprising, since the docs build uses ansible-core 2.13. It would need to use devel to pick this up.

felixfontein commented 1 year ago

Closing in favor of #263.