Closed briantist closed 1 year ago
github-actions[bot]
commented
1 year ago Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main
codecov[bot]
commented
1 year ago Merging #303 (105556e) into main (74835ab) will increase coverage by
0.13%. The diff coverage is100.00%.:exclamation: Current head 105556e differs from pull request most recent head b273ae2. Consider uploading reports for the commit b273ae2 to get more accurate results
@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 98.52% 98.66% +0.13%
==========================================
Files 73 73
Lines 3602 3679 +77
Branches 321 313 -8
==========================================
+ Hits 3549 3630 +81
+ Misses 44 40 -4
Partials 9 9 | Flag | Coverage Δ | |
|---|---|---|
| env_docker-default | 98.66% <100.00%> (+0.13%) |
:arrow_up: |
| integration | 81.02% <75.00%> (+0.08%) |
:arrow_up: |
| sanity | ? |
|
| target_ansible-doc | ? |
|
| target_auth_approle | 89.47% <ø> (ø) |
|
| target_auth_aws_iam | 50.00% <ø> (ø) |
|
| target_auth_azure | 53.84% <ø> (ø) |
|
| target_auth_cert | 86.36% <ø> (ø) |
|
| target_auth_jwt | 91.30% <ø> (ø) |
|
| target_auth_ldap | 89.47% <ø> (ø) |
|
| target_auth_none | 100.00% <ø> (ø) |
|
| target_auth_token | 73.07% <ø> (ø) |
|
| target_auth_userpass | 85.71% <ø> (ø) |
|
| target_connection_options | 74.76% <ø> (ø) |
|
| target_controller | ? |
|
| target_filter_vault_login_token | 77.77% <ø> (ø) |
|
| target_import | ? |
|
| target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
| target_lookup_vault_ansible_settings | 55.87% <ø> (ø) |
|
| target_lookup_vault_kv1_get | 91.30% <ø> (ø) |
|
| target_lookup_vault_kv2_get | 91.66% <ø> (ø) |
|
| target_lookup_vault_login | 88.57% <ø> (ø) |
|
| target_lookup_vault_read | 90.00% <ø> (ø) |
|
| target_lookup_vault_token_create | 79.24% <62.50%> (+1.06%) |
:arrow_up: |
| target_lookup_vault_write | 57.57% <ø> (ø) |
|
| target_module_utils | ? |
|
| target_module_vault_kv1_get | 87.50% <ø> (ø) |
|
| target_module_vault_kv2_get | 87.23% <ø> (ø) |
|
| target_module_vault_login | 83.72% <ø> (ø) |
|
| target_module_vault_pki_generate_certificate | 78.72% <ø> (ø) |
|
| target_module_vault_read | 85.71% <ø> (ø) |
|
| target_module_vault_token_create | 91.66% <87.50%> (+1.66%) |
:arrow_up: |
| target_module_vault_write | 56.46% <ø> (ø) |
|
| target_modules | ? |
|
| units | 96.22% <100.00%> (+0.44%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| plugins/doc_fragments/token_create.py | 100.00% <ø> (ø) |
|
| plugins/lookup/vault_token_create.py | 100.00% <100.00%> (+3.63%) |
:arrow_up: |
| plugins/modules/vault_token_create.py | 100.00% <100.00%> (+4.00%) |
:arrow_up: |
| ...sts/unit/plugins/lookup/test_vault_token_create.py | 100.00% <100.00%> (ø) |
|
| ...ts/unit/plugins/modules/test_vault_token_create.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
briantist
commented
1 year ago @felixfontein @acozine thank you for reviewing!
SUMMARY
Fixes #301
ISSUE TYPE
COMPONENT NAME
vault_token_create