Closed briantist closed 1 year ago
github-actions[bot]
commented
1 year ago Thank you for contribution!✨
This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main
codecov[bot]
commented
1 year ago Merging #317 (bcf7af0) into main (75e4c59) will increase coverage by
0.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 98.72% 98.75% +0.02%
==========================================
Files 75 75
Lines 3854 3859 +5
Branches 252 251 -1
==========================================
+ Hits 3805 3811 +6
+ Misses 40 39 -1
Partials 9 9 | Flag | Coverage Δ | |
|---|---|---|
| env_docker-default | 98.75% <100.00%> (+0.02%) |
:arrow_up: |
| integration | 80.97% <ø> (-0.11%) |
:arrow_down: |
| sanity | 39.09% <ø> (+0.08%) |
:arrow_up: |
| target_ansible-doc | 100.00% <ø> (ø) |
|
| target_auth_approle | 89.47% <ø> (ø) |
|
| target_auth_aws_iam | 50.00% <ø> (ø) |
|
| target_auth_azure | 53.84% <ø> (ø) |
|
| target_auth_cert | 86.36% <ø> (ø) |
|
| target_auth_jwt | 91.30% <ø> (ø) |
|
| target_auth_ldap | 89.47% <ø> (ø) |
|
| target_auth_none | 100.00% <ø> (ø) |
|
| target_auth_token | 71.42% <ø> (-1.65%) |
:arrow_down: |
| target_auth_userpass | 85.71% <ø> (ø) |
|
| target_connection_options | 74.76% <ø> (ø) |
|
| target_controller | 83.22% <ø> (-0.08%) |
:arrow_down: |
| target_filter_vault_login_token | 77.77% <ø> (ø) |
|
| target_import | 39.09% <ø> (+0.08%) |
:arrow_up: |
| target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
| target_lookup_vault_ansible_settings | 56.07% <ø> (+0.20%) |
:arrow_up: |
| target_lookup_vault_kv1_get | 91.30% <ø> (ø) |
|
| target_lookup_vault_kv2_get | 91.66% <ø> (ø) |
|
| target_lookup_vault_login | 88.57% <ø> (ø) |
|
| target_lookup_vault_read | 90.00% <ø> (ø) |
|
| target_lookup_vault_token_create | 79.24% <ø> (ø) |
|
| target_lookup_vault_write | 57.39% <ø> (-0.19%) |
:arrow_down: |
| target_module_utils | 97.36% <100.00%> (+0.27%) |
:arrow_up: |
| target_module_vault_kv1_get | 87.50% <ø> (ø) |
|
| target_module_vault_kv2_delete | 56.93% <ø> (-0.22%) |
:arrow_down: |
| target_module_vault_kv2_get | 87.23% <ø> (ø) |
|
| target_module_vault_login | 83.72% <ø> (ø) |
|
| target_module_vault_pki_generate_certificate | 78.72% <ø> (ø) |
|
| target_module_vault_read | 85.71% <ø> (ø) |
|
| target_module_vault_token_create | 91.66% <ø> (ø) |
|
| target_module_vault_write | 56.25% <ø> (-0.22%) |
:arrow_down: |
| target_modules | 80.65% <ø> (+0.14%) |
:arrow_up: |
| units | 96.55% <100.00%> (+0.18%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| plugins/doc_fragments/auth.py | 100.00% <ø> (ø) |
|
| plugins/lookup/vault_login.py | 100.00% <ø> (ø) |
|
| plugins/module_utils/_auth_method_token.py | 100.00% <ø> (+1.92%) |
:arrow_up: |
| plugins/module_utils/_authenticator.py | 100.00% <ø> (ø) |
|
| plugins/modules/vault_login.py | 100.00% <ø> (ø) |
|
| ...ins/module_utils/authentication/test_auth_token.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
briantist
commented
1 year ago @felixfontein thanks for reviewing this too!
SUMMARY
Resolves #248
ISSUE TYPE