ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 58 forks source link

✨ Feature Request: Dedicated Module for KV secrets #331

Closed nwerker closed 1 year ago

nwerker commented 1 year ago
SUMMARY

I've read through some of the issues and understand the scope of the modules and that the vault_write Module has it's particular scope and purpose. It would be nice to have a module specialized on KV secrets, with a certain behavior that makes it more suitable for some ansible tasks than the vault_write module.

ISSUE TYPE
COMPONENT NAME

Not defined yet

ADDITIONAL INFORMATION

This module should have the following functionality to set it apart from existing modules:

There is an existing module which implements this in quite a nice manner regarding the user experience. Terry Howe Module, however, there are a few reasons why I wish to see such functionality in this collection!

briantist commented 1 year ago

Hi @nwerker !

vault_write was never intended to be the extent of support for writing; rather it was meant to fill gaps in the absence of dedicated content, and the plan was always to fill out the collection with those.

I spent over a year setting up the module utils for shared functionality, shoring up tests and coverage, before finally being able to add those modules and plugins in a way that makes maximum use of shared code like auth methods.

The only thing stopping me from adding all of them myself is time; I'm spread pretty thin these days.

We have a contributor guide to help with that, and following existing plugins and modules should also help.

It's a lot easier for me to find time to help contributor PRs than to do them myself these days.


For you or anyone else interested here's an example of a recent dedicated module added by a contributor:

nwerker commented 1 year ago

@briantist

Completely understandable! I think this could be a good first issue / PR for new contributors.

I can empathise with the limited time, I will check within my organisation and come back to you or assign the issue to myself, when I know more!

devon-mar commented 1 year ago

@nwerker Are you working on this issue? If not, I can take a look at it.

nwerker commented 1 year ago

@devon-mar I hadn't had the time yet, so I'd be happy if you take a look at it!