briantist
commented
1 year ago Why was the exclude change reverted in 71857ff ? We do actually want that, could you restore?
Closed lowlydba closed 1 year ago
briantist
commented
1 year ago Why was the exclude change reverted in 71857ff ? We do actually want that, could you restore?
codecov[bot]
commented
1 year ago Merging #335 (71857ff) into main (a5ed14c) will not change coverage. The diff coverage is
n/a.:exclamation: Current head 71857ff differs from pull request most recent head 0a3f609. Consider uploading reports for the commit 0a3f609 to get more accurate results
@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 76 76
Lines 3862 3862
Branches 250 250
=======================================
Hits 3814 3814
Misses 39 39
Partials 9 9 | Flag | Coverage Δ | |
|---|---|---|
| env_docker-default | 98.75% <ø> (ø) |
|
| integration | 80.93% <ø> (ø) |
|
| sanity | 39.42% <ø> (ø) |
|
| target_ansible-doc | 100.00% <ø> (ø) |
|
| target_auth_approle | 89.47% <ø> (ø) |
|
| target_auth_aws_iam | 50.00% <ø> (ø) |
|
| target_auth_azure | 53.84% <ø> (ø) |
|
| target_auth_cert | 86.36% <ø> (ø) |
|
| target_auth_jwt | 91.30% <ø> (ø) |
|
| target_auth_ldap | 89.47% <ø> (ø) |
|
| target_auth_none | 100.00% <ø> (ø) |
|
| target_auth_token | 71.42% <ø> (ø) |
|
| target_auth_userpass | 85.71% <ø> (ø) |
|
| target_connection_options | 74.76% <ø> (ø) |
|
| target_controller | 83.20% <ø> (ø) |
|
| target_filter_vault_login_token | 77.77% <ø> (ø) |
|
| target_import | 39.42% <ø> (ø) |
|
| target_lookup_hashi_vault | 81.33% <ø> (ø) |
|
| target_lookup_vault_ansible_settings | 56.28% <ø> (ø) |
|
| target_lookup_vault_kv1_get | 91.30% <ø> (ø) |
|
| target_lookup_vault_kv2_get | 91.11% <ø> (ø) |
|
| target_lookup_vault_login | 88.57% <ø> (ø) |
|
| target_lookup_vault_read | 90.00% <ø> (ø) |
|
| target_lookup_vault_token_create | 79.24% <ø> (ø) |
|
| target_lookup_vault_write | 57.39% <ø> (ø) |
|
| target_module_utils | 97.36% <ø> (ø) |
|
| target_module_vault_kv1_get | 87.50% <ø> (ø) |
|
| target_module_vault_kv2_delete | 56.93% <ø> (ø) |
|
| target_module_vault_kv2_get | 87.23% <ø> (ø) |
|
| target_module_vault_login | 83.72% <ø> (ø) |
|
| target_module_vault_pki_generate_certificate | 78.72% <ø> (ø) |
|
| target_module_vault_read | 85.71% <ø> (ø) |
|
| target_module_vault_token_create | 91.66% <ø> (ø) |
|
| target_module_vault_write | 56.25% <ø> (ø) |
|
| target_modules | 80.65% <ø> (ø) |
|
| units | 96.55% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
lowlydba
commented
1 year ago Why was the exclude change reverted in 71857ff ? We do actually want that, could you restore?
I don't remember 😨
briantist
commented
1 year ago With the ansible-test updates backported to 2.14 & 2.13, I think this should now only explicitly use 20.04 in <=2.12 ; but it also seems like I have other problems in CI that I need to address. I may make a separate PR to fix it all at once when I'm back home and able to dedicate time to it. Let's keep this PR open for now just in case, thanks for putting this in anyway!
https://github.com/ansible-collections/news-for-maintainers/discussions/29