ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 58 forks source link

`hashi_vault` lookup - raise exception on duplicate term string options #375

Closed briantist closed 1 year ago

briantist commented 1 year ago
SUMMARY

Closes #356

See also:

ISSUE TYPE
codecov[bot] commented 1 year ago

Codecov Report

Merging #375 (165897b) into main (eed0111) will decrease coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head 165897b differs from pull request most recent head 56cbc6b. Consider uploading reports for the commit 56cbc6b to get more accurate results

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   98.86%   98.86%   -0.01%     
==========================================
  Files          82       82              
  Lines        4236     4234       -2     
  Branches      267      267              
==========================================
- Hits         4188     4186       -2     
  Misses         39       39              
  Partials        9        9              
Flag Coverage Δ
env_docker-default 98.86% <100.00%> (-0.01%) :arrow_down:
integration 81.31% <100.00%> (+0.24%) :arrow_up:
sanity 39.49% <50.00%> (+0.02%) :arrow_up:
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (ø)
target_auth_azure 53.84% <ø> (ø)
target_auth_cert 86.36% <ø> (ø)
target_auth_jwt 91.30% <ø> (ø)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (ø)
target_auth_token 71.42% <ø> (ø)
target_auth_userpass 85.71% <ø> (ø)
target_connection_options 74.76% <ø> (ø)
target_controller 83.93% <100.00%> (-0.02%) :arrow_down:
target_filter_vault_login_token 77.77% <ø> (ø)
target_import 39.49% <50.00%> (+0.02%) :arrow_up:
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 56.07% <50.00%> (+0.06%) :arrow_up:
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.11% <ø> (ø)
target_lookup_vault_list 90.00% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_read 90.00% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.14% <50.00%> (+0.08%) :arrow_up:
target_module_utils 97.48% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 56.93% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_kv2_write 57.32% <ø> (ø)
target_module_vault_list 85.71% <ø> (ø)
target_module_vault_login 83.72% <ø> (ø)
target_module_vault_pki_generate_certificate 78.72% <ø> (ø)
target_module_vault_read 85.71% <ø> (ø)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.25% <ø> (ø)
target_modules 82.09% <ø> (ø)
units 95.55% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugins/plugin_utils/_hashi_vault_lookup_base.py 100.00% <100.00%> (ø)
.../plugin_utils/base/test_hashi_vault_lookup_base.py 100.00% <100.00%> (ø)
briantist commented 1 year ago

@felixfontein thanks a lot for reviewing!