briantist
commented
3 years ago List of things to check/change
just trying to keep a running list of stuff in place so I don't forget. I'm sure more will turn up.
- github workflows
tests/config.yml-- update the required versions (this will only work in 2.12+ but still)tests/integrations/requirements.txttests/unit/requirements.txttests/unit/*check for areas where manual python version exclusion was needed (for 2.6). We'll likely need more of that to exclude 2.7 and 3.5 on ansible-core <=2.11 sincetests/config.ymlisn't supported on those- re-evaluate some of the
try/importblocks to see if some of the fallbacks are even needed anymore, or could be made better - update the comments in module & plugin utils code about supported versions of python
UPDATE: Python 3.5 support will also be dropped
As clarified in the
hvacthread, support for Python 3.5 will also be dropped along with 2.x, and for the same reasons below, this collection won't be able to easily support 3.5.Python 3.6 will be the minimum version for
community.hashi_vaultstarting in version2.0.0, keeping parity withhvac.Python 2 Support Will be Dropped in v2
As of the next major version, v2 (v2.0.0+) release of
community.hashi_vault, Python 2 will no longer be directly supported or tested against. At that time the minimum Python version will likely be Python 3.5, or 3.6 (tbd).Why?
We all know Py2 is EoL and projects are dropping support for it left and right, including Ansible (on the controller, where currently all content in this collection runs). This makes it harder and harder to keep supporting it, to work around CI and testing issues too. But the major driver for this decision is around the
hvaclibrary.All of the content in this collection currently relies on
hvacand is expected to indefinitely.hvacstill supports Python2, for now, however:hvac's own CI hasn't been testing against Python 2 since Feb 1: https://github.com/hvac/hvac/issues/582#issuecomment-7710102640.10.12and0.10.13(see https://github.com/hvac/hvac/issues/706 and https://github.com/hvac/hvac/issues/711)Even if
hvacdoes not explicitly drop support, it's clear the lack of testing against it is a problem, and given the other difficulty of continuing to support it, I feel announcing the end of support in this collection's next major version is prudent.This post will be updated with more information as it becomes available.