ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
80 stars 59 forks source link

tests - replace use of Vault CLI to configure the Vault server #88

Closed briantist closed 3 years ago

briantist commented 3 years ago
SUMMARY

This PR adds several modules for use within the integration tests, replacing use of the Vault CLI (Vault binary) to configure a running Vault server, with small Python modules that use hvac to communicate with the server instead.

This is an important step toward making the tests be able to run against a configurable vault target server without needing the Vault binary available.

This will unlock wider options for being able to run the Vault test server in a container, or use a pre-running server, etc.

It also makes it easier to separate out the Vault server configuration steps into their own setup_ targets, which is going to help a lot with improving the way tests get run and invoked, which will make testing of new plugins and modules easier.

This PR doesn't do any of that yet (I have other PRs and local branches working on some of those things), getting this landed is the first step in moving those along.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 3 years ago

Codecov Report

Merging #88 (a9520e0) into main (92d7368) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files          16       16           
  Lines         783      783           
  Branches       78       78           
=======================================
  Hits          649      649           
  Misses        120      120           
  Partials       14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92d7368...a9520e0. Read the comment docs.