search

ansible-collections / community.hashi_vault

Ansible collection for managing and working with HashiCorp Vault.
https://docs.ansible.com/ansible/devel/collections/community/hashi_vault/index.html
GNU General Public License v3.0
81 stars 62 forks source link

tests - allow for external proxy #92

Closed briantist closed 3 years ago

briantist commented 3 years ago
SUMMARY

Building on #88 and #90 , this PR removed the duplicated proxy address references, and sets up the tests for working with an external tinyproxy (really any proxy I guess) rather than having the tests install and manage one.

It doesn't change the CI to use an external proxy in a container yet even though it could, because we're not yet able to use Vault in an external container, and the proxy can't reach Vault running in the test container ☹ as we have no way to address the container managed by ansible-test through name or IP.

ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 3 years ago

Codecov Report

Merging #92 (f89b196) into main (7e4450a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files          16       16           
  Lines         783      783           
  Branches       78       78           
=======================================
  Hits          649      649           
  Misses        120      120           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e4450a...f89b196. Read the comment docs.