search

ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

Do not mark task as changed when diff is irrelevant #228

Closed fabianvf closed 4 years ago

fabianvf commented 4 years ago
SUMMARY

When the diff contains changes only to the fields metadata.generation or metadata.resourceVersion, do not mark the task as changed. Instead, emit a warning highlighting that the API itself may not be idempotent, but that there was no meaningful difference between the desired and actual state of the resource.

ISSUE TYPE
COMPONENT NAME

plugins/modules/k8s.py

ADDITIONAL INFORMATION
codecov[bot] commented 4 years ago

Codecov Report

Merging #228 into main will decrease coverage by 0.71%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   43.38%   42.66%   -0.72%     
==========================================
  Files           4        4              
  Lines         597      607      +10     
  Branches      118      122       +4     
==========================================
  Hits          259      259              
- Misses        291      301      +10     
  Partials       47       47
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 38.72% <0.00%> (-1.73%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 527859c...0afe40e. Read the comment docs.