search

ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 106 forks source link

Fix the downstream build and release process #259

Closed geerlingguy closed 3 years ago

geerlingguy commented 3 years ago
SUMMARY

Fixes #254.

ISSUE TYPE
COMPONENT NAME

Makefile and utils/downstream.sh

ADDITIONAL INFORMATION

N/A

codecov[bot] commented 3 years ago

Codecov Report

Merging #259 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   36.74%   36.74%           
=======================================
  Files           3        3           
  Lines         724      724           
  Branches      144      144           
=======================================
  Hits          266      266           
  Misses        409      409           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbd3a25...217906c. Read the comment docs.

geerlingguy commented 3 years ago

Hmm... so that sed change definitely doesn't work on Linux. Drat.

I found this answer which creates a bunch of .bak files and is cross-platform. I could add one more line after all the sed invocations finding and deleting all .bak files in the collection directory...