search

ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

Fix default configuration getter in client v12.0.0 #276

Closed jaydesl closed 4 years ago

jaydesl commented 4 years ago
SUMMARY

Use get_default_copy() to load the default configuration. Fixes #273

ISSUE TYPE
COMPONENT NAME

k8s module

ADDITIONAL INFORMATION

See also kubernetes-client/python#1284

codecov[bot] commented 4 years ago

Codecov Report

Merging #276 into main will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   36.74%   37.00%   +0.26%     
==========================================
  Files           3        3              
  Lines         724      727       +3     
  Branches      144      144              
==========================================
+ Hits          266      269       +3     
  Misses        409      409              
  Partials       49       49
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 35.92% <0.00%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d038237...e768747. Read the comment docs.

fabianvf commented 4 years ago

Yep, looks good to me once there's a test

jaydesl commented 4 years ago

Thoughts on this as a test?

Akasurde commented 4 years ago

@jaydesl Thanks for adding test and fix.