ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

molecule: use the new charts repository #294

Closed goneri closed 4 years ago

goneri commented 4 years ago

molecule: use the new charts repository

Since October, 26th, the sable repository has a new location. See: https://helm.sh/blog/new-location-stable-incubator-charts/

Without this change, the test-suite fails because of the following error:

$ `helm repo add test_helm_repo https://kubernetes-charts.storage.googleapis.com`
Error: repo "https://kubernetes-charts.storage.googleapis.com" is no longer available; try "https://charts.helm.sh/stable" instead
codecov[bot] commented 4 years ago

Codecov Report

Merging #294 (b329652) into main (77e48d0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   37.00%   37.00%           
=======================================
  Files           3        3           
  Lines         727      727           
  Branches      144      144           
=======================================
  Hits          269      269           
  Misses        409      409           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77e48d0...b329652. Read the comment docs.

geerlingguy commented 4 years ago

@goneri - Strange... if I load https://kubernetes-charts.storage.googleapis.com I can get the XML just fine.

Also, if I look at the https://charts.helm.sh/stable/ page, it mentions a Deprecation and Archive Notice, which seems to indicate it shouldn't be used for anything moving forward.

Maybe we should pick some other repo that has a better chance of sticking around a long time?

goneri commented 4 years ago

@goneri - Strange... if I load https://kubernetes-charts.storage.googleapis.com I can get the XML just fine.

Also, if I look at the https://charts.helm.sh/stable/ page, it mentions a Deprecation and Archive Notice, which seems to indicate it shouldn't be used for anything moving forward.

Maybe we should pick some other repo that has a better chance of sticking around a long time?

Hum weird. I hit another wall after that, nginx-ingress-1.32.0.tgz don't seem to be online anymore. But well, It may totally be because of my set-up. It's the first time I try to run the test-suite.

goneri commented 4 years ago
[goneri@t580-gone kubernetes]$ helm repo add test_helm_repo https://kubernetes-charts.storage.googleapis.com
Error: repo "https://kubernetes-charts.storage.googleapis.com" is no longer available; try "https://charts.helm.sh/stable" instead
goneri commented 4 years ago

The new location has been announced here: https://helm.sh/blog/new-location-stable-incubator-charts/

goneri commented 4 years ago

There is still some problem, but are you ok with this strategy?

geerlingguy commented 4 years ago

I think if we're going to move to a different charts repository, we should just move to one that we know will be maintained/stable, and not move to https://charts.helm.sh/stable/, which says it is deprecated already and on November 13 (less than a week away) it will stop working entirely...

goneri commented 4 years ago

I think if we're going to move to a different charts repository, we should just move to one that we know will be maintained/stable, and not move to https://charts.helm.sh/stable/, which says it is deprecated already and on November 13 (less than a week away) it will stop working entirely...

Oh, good point. The new home of ingress-nginx seems to be https://kubernetes.github.io/ingress-nginx. I give it a try.

geerlingguy commented 4 years ago

Thanks for all the work on this—closing in favor of #297