ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

refactoring for ansible_module.turbo integration #313

Closed goneri closed 3 years ago

goneri commented 3 years ago

This refactoring prepares the integration of ansible_module.turbo

See: https://github.com/ansible-collections/community.kubernetes/pull/270

codecov[bot] commented 3 years ago

Codecov Report

Merging #313 (cefd139) into main (2f6fae3) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   23.17%   23.17%           
=======================================
  Files           1        1           
  Lines         151      151           
  Branches       24       24           
=======================================
  Hits           35       35           
  Misses        111      111           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f6fae3...cefd139. Read the comment docs.

gravesm commented 3 years ago

Per @fabianvf we should make sure that these changes don't impact the okd collection, as it imports a fair amount from this one.

fabianvf commented 3 years ago

@gravesm I think the impact is almost certain, we'd just need to ensure we've got pins in place on the okd collection to not pull in an updated community.kubernetes collection until it has been updated. Don't think it needs to block this PR though as long as the work is on our radar and done before a community.kubernetes release would be cut.

gravesm commented 3 years ago

@goneri can you rebase this when you get a chance? We should be able to get this reviewed and merged now that 1.2 has been released.

jillr commented 3 years ago

I can't actually run sanity on this locally (I need to figure out what's up with that on my machine) but I've got a PR to @goneri's branch that I think should solve the failures here.

github-actions[bot] commented 3 years ago

This repository does not accept pull requests, see the README for details.