search

ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 106 forks source link

helm: add support for the K8S_ envvars #319

Closed goneri closed 3 years ago

goneri commented 3 years ago

Depends-On: https://github.com/ansible-collections/community.kubernetes/pull/324

Add support for:

This commit also refactor the way we pass K8S related configuration to helm:

All the calls are now done in a new moduleutils module (helm.py). The handling of the `kube*` variables has also been moved in this new module.

We need https://github.com/helm/helm/pull/8622 to be able to ignore the certificate validation. As a workaround, the generate a temporary kubeconfig configuration file.

Closes: #279

codecov[bot] commented 3 years ago

Codecov Report

Merging #319 (beb412b) into main (befc0f6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   37.03%   37.03%           
=======================================
  Files           3        3           
  Lines         729      729           
  Branches      144      144           
=======================================
  Hits          270      270           
  Misses        410      410           
  Partials       49       49

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update befc0f6...beb412b. Read the comment docs.

tima commented 3 years ago

It looks like @Akasurde's changes requests where addressed so I'm going to merge this one.

goneri commented 3 years ago

Thanks for the review.