ansible-collections / community.kubernetes

Kubernetes Collection for Ansible

https://galaxy.ansible.com/community/kubernetes

GNU General Public License v3.0

265 stars 106 forks source link

add 3 doc-default-does-not-match-spec errors #325

Closed goneri closed 3 years ago

goneri commented 3 years ago

Address the following error with the test-suite:

plugins/modules/k8s.py:0:0: doc-default-does-not-match-spec: Argument 'append_hash' in argument_spec defines default as (False) but documentation defines default as (None)
plugins/modules/k8s.py:0:0: doc-default-does-not-match-spec: Argument 'apply' in argument_spec defines default as (False) but documentation defines default as (None)
plugins/modules/k8s_service.py:0:0: doc-default-does-not-match-spec: Argument 'apply' in argument_spec defines default as (False) but documentation defines default as (None)

codecov[bot] commented 3 years ago

Codecov Report

Merging #325 (81e410e) into main (4b447cc) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   37.03%   37.03%           
=======================================
  Files           3        3           
  Lines         729      729           
  Branches      144      144           
=======================================
  Hits          270      270           
  Misses        410      410           
  Partials       49       49

Impacted Files	Coverage Δ
...ctions/community/kubernetes/plugins/modules/k8s.py	`97.77% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b447cc...81e410e. Read the comment docs.

geerlingguy commented 3 years ago

@goneri - I believe @Akasurde was also working on this separately in one of his PRs... but I would like to have it separated anyways, so we can merge it independent of whatever other work is going on in PRs currently.

goneri commented 3 years ago

@goneri - I believe @Akasurde was also working on this separately in one of his PRs... but I would like to have it separated anyways, so we can merge it independent of whatever other work is going on in PRs currently.

Indeed, I just saw his fixes: https://github.com/ansible-collections/community.kubernetes/pull/320/files#diff-0f6f43c36182e7fd2b2d7f77c3dafc90ae60a782ed8831830916504505211b2b

I also prefer when a patch address a single issue.