search

ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 104 forks source link

Add support for configuring garbage collection #334

Closed gravesm closed 3 years ago

gravesm commented 3 years ago
SUMMARY

This surfaces deleteOptions functionality in a top-level delete_options parameter. delete_options can be used to control garbage collection behavior at the time of resource deletion.

Closes #253.

ISSUE TYPE
COMPONENT NAME

k8s.py

ADDITIONAL INFORMATION

A few things to note:

  1. I have left off the dryRun parameter as it seems like this would conflict with ansible's check mode.
  2. apiVersion and kind are included, but I'm not sure how useful they are in this context. kind in particular can only be DeleteOptions.
codecov[bot] commented 3 years ago

Codecov Report

Merging #334 (202ebbf) into main (221631c) will increase coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #334      +/-   ##
==========================================
+ Coverage   37.02%   37.18%   +0.15%     
==========================================
  Files           3        3              
  Lines         732      745      +13     
  Branches      144      144              
==========================================
+ Hits          271      277       +6     
- Misses        412      419       +7     
  Partials       49       49
Impacted Files Coverage Δ
...ommunity/kubernetes/plugins/module_utils/common.py 35.94% <0.00%> (-0.03%) :arrow_down:
...ctions/community/kubernetes/plugins/modules/k8s.py 97.82% <0.00%> (+0.04%) :arrow_up:
...ns/community/kubernetes/plugins/action/k8s_info.py 23.17% <0.00%> (+1.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 221631c...202ebbf. Read the comment docs.