ansible-collections / community.kubernetes

Kubernetes Collection for Ansible
https://galaxy.ansible.com/community/kubernetes
GNU General Public License v3.0
265 stars 106 forks source link

helm - remove trailing whitespaces (#337) #345

Closed alinabuzachis closed 3 years ago

alinabuzachis commented 3 years ago
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
codecov[bot] commented 3 years ago

Codecov Report

Merging #345 (dee55a3) into main (a9b8cc6) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #345   +/-   ##
=======================================
  Coverage   36.93%   36.93%           
=======================================
  Files           3        3           
  Lines         750      750           
  Branches      146      146           
=======================================
  Hits          277      277           
  Misses        424      424           
  Partials       49       49           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9b8cc6...dee55a3. Read the comment docs.

goneri commented 3 years ago

Hi @alinabuzachis, Does this PR fix an existing opened issue?

tima commented 3 years ago

@goneri I has some reservations about this one. Isn't this breaking from convention to how Engine works? The rest of Ansible engine doesn't strip whitespace like this. We should be consistent with that and not introduce something that breaks with that convention because one person made a typo.

goneri commented 3 years ago

Sorry, I understand. @tima I just pushed a PR to revert the patch.