Closed Akasurde closed 3 years ago
Merging #358 (394a021) into main (5a5ed79) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 36.80% 36.80%
=======================================
Files 3 3
Lines 758 758
Branches 148 148
=======================================
Hits 279 279
Misses 430 430
Partials 49 49
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5a5ed79...839aa0b. Read the comment docs.
I'm fine with the change, but I wonder if it might be better to push this to 2.0 since it will break any existing playbooks using these modules? Maybe we should remove the required
attribute of this parameter for 1.2, which would fix the reported bug, and then merge this change in 2.0?
Make sense to me.
This repository does not accept pull requests, see the README for details.
SUMMARY
Modules modified -
Fixes: #357
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
COMPONENT NAME
changelogs/fragments/357_helm_plugin.yml plugins/modules/helm_plugin.py plugins/modules/helm_plugin_info.py